Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: src/ic/ia32/handler-compiler-ia32.cc

Issue 1376933006: Vector ICs: Get rid of stack arguments on ia32 transitioning stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Code comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/handler-compiler.cc ('k') | src/ic/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ia32/handler-compiler-ia32.cc
diff --git a/src/ic/ia32/handler-compiler-ia32.cc b/src/ic/ia32/handler-compiler-ia32.cc
index 1d019092c7b91812cda2ad26c38e9f86d2625d18..2aff4847e27a35239785753477c82a8cbb50835a 100644
--- a/src/ic/ia32/handler-compiler-ia32.cc
+++ b/src/ic/ia32/handler-compiler-ia32.cc
@@ -362,18 +362,16 @@ void NamedStoreHandlerCompiler::GenerateRestoreName(Handle<Name> name) {
}
-void NamedStoreHandlerCompiler::GeneratePushMap(Register map_reg,
- Register scratch) {
- // current after GeneratePushMap
- // -------------------------------------------------
- // ret addr slot
- // vector vector
- // sp -> slot map
- // sp -> ret addr
- //
- __ xchg(map_reg, Operand(esp, 0));
- __ xchg(map_reg, Operand(esp, 2 * kPointerSize));
- __ push(map_reg);
+void NamedStoreHandlerCompiler::RearrangeVectorAndSlot(
+ Register current_map, Register destination_map) {
+ DCHECK(destination_map.is(StoreTransitionHelper::MapRegister()));
+ DCHECK(current_map.is(StoreTransitionHelper::VectorRegister()));
+ ExternalReference virtual_slot =
+ ExternalReference::virtual_slot_register(isolate());
+ __ mov(destination_map, current_map);
+ __ pop(current_map);
+ __ mov(Operand::StaticVariable(virtual_slot), current_map);
+ __ pop(current_map); // put vector in place.
}
« no previous file with comments | « src/ic/handler-compiler.cc ('k') | src/ic/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698