Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2127)

Unified Diff: src/code-stubs.h

Issue 1376933006: Vector ICs: Get rid of stack arguments on ia32 transitioning stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Code comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 2d7ace58dab57775e343909e41400901341e9a0a..4d552ed506d918b0369e056a909bd22284886ad0 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1244,8 +1244,10 @@ class StoreTransitionHelper {
}
static Register MapRegister() {
- return FLAG_vector_stores ? VectorStoreTransitionDescriptor::MapRegister()
- : StoreTransitionDescriptor::MapRegister();
+ if (FLAG_vector_stores) {
+ return VectorStoreTransitionDescriptor::MapRegister();
+ }
+ return StoreTransitionDescriptor::MapRegister();
}
static int ReceiverIndex() {
@@ -1256,26 +1258,25 @@ class StoreTransitionHelper {
static int ValueIndex() { return StoreTransitionDescriptor::kValueIndex; }
- static int SlotIndex() {
- DCHECK(FLAG_vector_stores);
- return VectorStoreTransitionDescriptor::kSlotIndex;
+ static int MapIndex() {
+ DCHECK(static_cast<int>(VectorStoreTransitionDescriptor::kMapIndex) ==
+ static_cast<int>(StoreTransitionDescriptor::kMapIndex));
+ return StoreTransitionDescriptor::kMapIndex;
}
static int VectorIndex() {
DCHECK(FLAG_vector_stores);
+ if (HasVirtualSlotArg()) {
+ return VectorStoreTransitionDescriptor::kVirtualSlotVectorIndex;
+ }
return VectorStoreTransitionDescriptor::kVectorIndex;
}
- static int MapIndex() {
- if (FLAG_vector_stores) {
- return VectorStoreTransitionDescriptor::kMapIndex;
- }
- return StoreTransitionDescriptor::kMapIndex;
+ // Some platforms don't have a slot arg.
+ static bool HasVirtualSlotArg() {
+ if (!FLAG_vector_stores) return false;
+ return SlotRegister().is(no_reg);
}
-
- // Some platforms push Slot, Vector, Map on the stack instead of in
- // registers.
- static bool UsesStackArgs() { return MapRegister().is(no_reg); }
};
« no previous file with comments | « src/assembler.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698