Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1376923003: cmake tweaks (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org, Marco A.
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

cmake tweaks • -w silences all warnings current and future. We're not using this for development. • There's no real need to exclude files in Release mode. The linker may whine a little, but that's fine. • Quiet down message() calls that run every time. They're fine if you can figure out how to run them only when doing the detection and cache them like all the others, but I don't like the noise seeing them every run. • cheaders is hard to read. c_headers. • ../src/*mac* erroneously picks up SkLumaColorFilter on non-case-sensitive file systems. ../src/*_mac* seems fine. CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot BUG=skia: Committed: https://skia.googlesource.com/skia/+/a5b0f0318b6fdcd05006365323b47b1bc046f799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M cmake/CMakeLists.txt View 4 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376923003/1
5 years, 2 months ago (2015-09-29 19:43:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376923003/1
5 years, 2 months ago (2015-09-29 19:49:24 UTC) #5
mtklein_C
5 years, 2 months ago (2015-09-29 19:54:53 UTC) #8
mtklein_C
5 years, 2 months ago (2015-09-29 19:54:53 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-29 19:56:23 UTC) #11
hal.canary
lgtm
5 years, 2 months ago (2015-09-29 20:15:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376923003/1
5 years, 2 months ago (2015-09-29 20:15:49 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 20:16:39 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a5b0f0318b6fdcd05006365323b47b1bc046f799

Powered by Google App Engine
This is Rietveld 408576698