Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1376913004: win: Disable ASLR on test binary that uses fixed base (Closed)

Created:
5 years, 2 months ago by scottmg
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Disable ASLR on test binary that uses fixed base This causes a link error on msvs builds which we don't care about, but in general if build/common.gypi forced RandomizedBaseAddress (e.g. in Chrome), it makes sense to be explicit about disabling it for this binary. R=mark@chromium.org BUG=https://groups.google.com/a/chromium.org/d/msg/crashpad-dev/jMtnDldRnJI/kNx7ZDxMAwAJ Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1e3ca26f16b3124cd8ae208ceb1d47447dc46b05

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M util/util_test.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
https://codereview.chromium.org/1376913004/diff/1/util/util_test.gyp File util/util_test.gyp (right): https://codereview.chromium.org/1376913004/diff/1/util/util_test.gyp#newcode128 util/util_test.gyp:128: 'FixedBaseAddress': '2', # Enabled. This is the same as ...
5 years, 2 months ago (2015-10-01 17:08:09 UTC) #1
Mark Mentovai
I think that mini_chromium’s common.gypi should specify randomized base addresses, actually. https://codereview.chromium.org/1376913004/diff/1/util/util_test.gyp File util/util_test.gyp (right): ...
5 years, 2 months ago (2015-10-01 17:56:48 UTC) #2
Mark Mentovai
LGTM
5 years, 2 months ago (2015-10-01 17:56:51 UTC) #3
scottmg
https://codereview.chromium.org/1376913004/diff/1/util/util_test.gyp File util/util_test.gyp (right): https://codereview.chromium.org/1376913004/diff/1/util/util_test.gyp#newcode128 util/util_test.gyp:128: 'FixedBaseAddress': '2', # Enabled. On 2015/10/01 17:56:48, Mark Mentovai ...
5 years, 2 months ago (2015-10-01 18:13:38 UTC) #4
scottmg
5 years, 2 months ago (2015-10-01 18:13:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1e3ca26f16b3124cd8ae208ceb1d47447dc46b05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698