Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1376883002: Isolate breakpad_unittests. (Closed)

Created:
5 years, 2 months ago by ghost stip (do not use)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Isolate breakpad_unittests. BUG=525873 Committed: https://crrev.com/70768b4875f49c92244d19ebd1378e636d35a715 Cr-Commit-Position: refs/heads/master@{#351584}

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M breakpad/breakpad.gyp View 1 chunk +21 lines, -0 lines 2 comments Download
A + breakpad/breakpad_unittests_apk.isolate View 1 chunk +5 lines, -3 lines 3 comments Download
M build/android/android.isolate View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 15 (2 generated)
ghost stip (do not use)
maruel/jbudorick: review thestig: OWNERS https://codereview.chromium.org/1376883002/diff/1/breakpad/breakpad_unittests_apk.isolate File breakpad/breakpad_unittests_apk.isolate (right): https://codereview.chromium.org/1376883002/diff/1/breakpad/breakpad_unittests_apk.isolate#newcode16 breakpad/breakpad_unittests_apk.isolate:16: 'breakpad_unittests.isolate', 'sup https://codereview.chromium.org/1376883002/diff/1/build/android/android.isolate File build/android/android.isolate ...
5 years, 2 months ago (2015-09-29 17:49:20 UTC) #2
M-A Ruel
lgtm
5 years, 2 months ago (2015-09-29 17:51:01 UTC) #3
Lei Zhang
Is there a GN equivalent change to the change in breakpad.gyp?
5 years, 2 months ago (2015-09-29 17:59:30 UTC) #4
jbudorick
https://codereview.chromium.org/1376883002/diff/1/breakpad/breakpad.gyp File breakpad/breakpad.gyp (right): https://codereview.chromium.org/1376883002/diff/1/breakpad/breakpad.gyp#newcode991 breakpad/breakpad.gyp:991: 'target_name': 'breakpad_unittests_apk_run', breakpad_unittests aren't packaged as an APK, so ...
5 years, 2 months ago (2015-09-29 18:00:11 UTC) #5
ghost stip (do not use)
On 2015/09/29 17:59:30, Lei Zhang wrote: > Is there a GN equivalent change to the ...
5 years, 2 months ago (2015-09-29 20:51:12 UTC) #6
ghost stip (do not use)
https://codereview.chromium.org/1376883002/diff/1/breakpad/breakpad.gyp File breakpad/breakpad.gyp (right): https://codereview.chromium.org/1376883002/diff/1/breakpad/breakpad.gyp#newcode991 breakpad/breakpad.gyp:991: 'target_name': 'breakpad_unittests_apk_run', On 2015/09/29 18:00:11, jbudorick wrote: > breakpad_unittests ...
5 years, 2 months ago (2015-09-29 20:53:00 UTC) #7
Lei Zhang
On 2015/09/29 20:51:12, stip wrote: > On 2015/09/29 17:59:30, Lei Zhang wrote: > > Is ...
5 years, 2 months ago (2015-09-29 21:18:40 UTC) #8
ghost stip (do not use)
(waits for jbudorick's comments or OK)
5 years, 2 months ago (2015-09-29 21:41:11 UTC) #9
jbudorick
lgtm https://codereview.chromium.org/1376883002/diff/1/breakpad/breakpad_unittests_apk.isolate File breakpad/breakpad_unittests_apk.isolate (right): https://codereview.chromium.org/1376883002/diff/1/breakpad/breakpad_unittests_apk.isolate#newcode16 breakpad/breakpad_unittests_apk.isolate:16: 'breakpad_unittests.isolate', On 2015/09/29 at 17:49:20, stip wrote: > ...
5 years, 2 months ago (2015-09-30 08:18:40 UTC) #10
jbudorick
https://codereview.chromium.org/1376883002/diff/1/breakpad/breakpad_unittests_apk.isolate File breakpad/breakpad_unittests_apk.isolate (right): https://codereview.chromium.org/1376883002/diff/1/breakpad/breakpad_unittests_apk.isolate#newcode16 breakpad/breakpad_unittests_apk.isolate:16: 'breakpad_unittests.isolate', On 2015/09/30 at 08:18:40, jbudorick wrote: > On ...
5 years, 2 months ago (2015-09-30 09:33:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376883002/1
5 years, 2 months ago (2015-09-30 16:04:18 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 17:12:21 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 17:14:19 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/70768b4875f49c92244d19ebd1378e636d35a715
Cr-Commit-Position: refs/heads/master@{#351584}

Powered by Google App Engine
This is Rietveld 408576698