Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: pkg/compiler/lib/src/compile_time_constants.dart

Issue 1376863004: Avoid eager enqueueing from resolution (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Update minimal_resolution_test. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/compile_time_constants.dart
diff --git a/pkg/compiler/lib/src/compile_time_constants.dart b/pkg/compiler/lib/src/compile_time_constants.dart
index a9776490f4b075942d463503bc298f84a9d4827a..4af20691612c70395cad03ff5f663fbb58f8a10e 100644
--- a/pkg/compiler/lib/src/compile_time_constants.dart
+++ b/pkg/compiler/lib/src/compile_time_constants.dart
@@ -1259,10 +1259,9 @@ class ErroneousAstConstant extends AstConstant {
new ErroneousConstantExpression(), new NullConstantValue());
}
-// TODO(johnniwinther): Avoid the need for this hack.
+// TODO(johnniwinther): Clean this up.
TreeElements _analyzeElementEagerly(Compiler compiler, AstElement element) {
- WorldImpact worldImpact = compiler.analyzeElement(element.declaration);
- compiler.enqueuer.resolution.applyImpact(element.declaration, worldImpact);
+ compiler.resolution.analyzeElement(element.declaration);
return element.resolvedAst.elements;
}

Powered by Google App Engine
This is Rietveld 408576698