src/heap/incremental-marking.cc - Issue 1376753002: [heap] Remove NewSpace::set_top and the corresponding hack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/incremental-marking.cc

Issue 1376753002: [heap] Remove NewSpace::set_top and the corresponding hack (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/incremental-marking.cc

diff --git a/src/heap/incremental-marking.cc b/src/heap/incremental-marking.cc

index 51b91badccaf7ef01b60096b808f062d5671bc0e..39ee846f3dba7c23d1bfe182a2c8f3a66813d807 100644

--- a/src/heap/incremental-marking.cc

+++ b/src/heap/incremental-marking.cc

@@ -901,8 +901,7 @@ intptr_t IncrementalMarking::Step(intptr_t allocated_bytes,

CompletionAction action,

ForceMarkingAction marking,

ForceCompletionAction completion) {

- // Temporarily removed for crbug.com/536163

- // DCHECK(allocated_bytes >= 0);

+ DCHECK(allocated_bytes >= 0);

if (heap_->gc_state() != Heap::NOT_IN_GC || !FLAG_incremental_marking ||

(state_ != SWEEPING && state_ != MARKING)) {

« no previous file with comments | « no previous file | src/heap/spaces.h » ('j') | no next file with comments »