Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1376753002: [heap] Remove NewSpace::set_top and the corresponding hack (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, ofrobots
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove NewSpace::set_top and the corresponding hack - Remove the hack the resets the new space top pointer from SeqString::Truncate. - Remove NewSpace::set_top completely as there are no callers (and there should be no!) R=hpayer@chromium.org BUG=chromium:536163 LOG=N Committed: https://crrev.com/92a7012b8b22227167eb1212c9d1592cf2e37510 Cr-Commit-Position: refs/heads/master@{#31004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M src/heap/incremental-marking.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376753002/1
5 years, 2 months ago (2015-09-29 12:40:31 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-29 13:03:57 UTC) #4
Michael Lippautz
Ali: FYI
5 years, 2 months ago (2015-09-29 13:05:11 UTC) #8
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-09-29 13:05:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376753002/1
5 years, 2 months ago (2015-09-29 13:05:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 13:07:32 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 13:07:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92a7012b8b22227167eb1212c9d1592cf2e37510
Cr-Commit-Position: refs/heads/master@{#31004}

Powered by Google App Engine
This is Rietveld 408576698