Issue 1376733005: [GN]: Include asmflags in ConfigValues::AppendValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1376733005: [GN]: Include asmflags in ConfigValues::AppendValues (Closed)

Created:
5 years, 2 months ago by Bons

Modified:
5 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[GN]: Include asmflags in ConfigValues::AppendValues This ensures that any subconfig asmflags values apply to a config that references it. BUG=none TBR=brettw@chromium.org Committed: https://crrev.com/1437d0fd62fe019f3cb9f663f81da5d4233e1044 Cr-Commit-Position: refs/heads/master@{#351583}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/gn/config_values.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376733005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376733005/1

5 years, 2 months ago (2015-09-30 16:56:38 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/1437d0fd62fe019f3cb9f663f81da5d4233e1044 Cr-Commit-Position: refs/heads/master@{#351583}

5 years, 2 months ago (2015-09-30 17:11:36 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages