chrome/browser/media/router/media_router_mojo_impl.cc - Issue 1376703002: Presentation API: reject screen availability observing on Android low ram devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/media_router_mojo_impl.cc

Issue 1376703002: Presentation API: reject screen availability observing on Android low ram devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix and add tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/media_router_mojo_impl.h ('k') | chrome/browser/media/router/media_router_mojo_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/media_router_mojo_impl.cc

diff --git a/chrome/browser/media/router/media_router_mojo_impl.cc b/chrome/browser/media/router/media_router_mojo_impl.cc

index cfdd2b8d355f2b346a4fab1c63550b3c26781c9b..a630e617fd2b1514e31b350e15e6fb911cdc2078 100644

--- a/chrome/browser/media/router/media_router_mojo_impl.cc

+++ b/chrome/browser/media/router/media_router_mojo_impl.cc

@@ -275,7 +275,7 @@ void MediaRouterMojoImpl::OnPresentationSessionDetached(

base::Unretained(this), route_id));

}

-void MediaRouterMojoImpl::RegisterMediaSinksObserver(

+bool MediaRouterMojoImpl::RegisterMediaSinksObserver(

MediaSinksObserver* observer) {

DCHECK(thread_checker_.CalledOnValidThread());

@@ -297,6 +297,7 @@ void MediaRouterMojoImpl::RegisterMediaSinksObserver(

observer_list->AddObserver(observer);

RunOrDefer(base::Bind(&MediaRouterMojoImpl::DoStartObservingMediaSinks,

base::Unretained(this), source_id));

+ return true;

}

void MediaRouterMojoImpl::UnregisterMediaSinksObserver(