chrome/browser/media/router/media_router.h - Issue 1376703002: Presentation API: reject screen availability observing on Android low ram devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/media_router.h

Issue 1376703002: Presentation API: reject screen availability observing on Android low ram devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix and add tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/android/router/media_router_android.cc ('k') | chrome/browser/media/router/media_router_mojo_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/media_router.h

diff --git a/chrome/browser/media/router/media_router.h b/chrome/browser/media/router/media_router.h

index 0a335654b0f7566eb83ce3132d173a7ea675128f..cbf5404404e5f9e888e622f9984055255be138fb 100644

--- a/chrome/browser/media/router/media_router.h

+++ b/chrome/browser/media/router/media_router.h

@@ -133,7 +133,9 @@ class MediaRouter : public KeyedService {

// in undefined behavior.

// If the MRPM Host is not available, the registration request will fail

// immediately.

- virtual void RegisterMediaSinksObserver(MediaSinksObserver* observer) = 0;

+ // The implementation can reject the request to observe in which case it will

+ // notify the caller by returning |false|.

+ virtual bool RegisterMediaSinksObserver(MediaSinksObserver* observer) = 0;

// Removes a previously added MediaSinksObserver. |observer| will stop

// receiving further updates.