Presentation API: reject screen availability observing on Android low ram devices.

chrome/browser/media/router/presentation_service_delegate_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/router/presentation_service_delegate_impl.h"
 
 #include <string>
 
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/containers/small_map.h"
@@ skipping 160 matching lines @@
 
 const std::vector<MediaRoute::Id> PresentationFrame::GetRouteIds() const {
   std::vector<MediaRoute::Id> route_ids;
   for (const auto& e : presentation_id_to_route_id_)
     route_ids.push_back(e.second);
   return route_ids;
 }
 
 bool PresentationFrame::SetScreenAvailabilityListener(
     content::PresentationScreenAvailabilityListener* listener) {
-  if (sinks_observer_ && sinks_observer_->listener() == listener) {
+  if (sinks_observer_ && sinks_observer_->listener() == listener)
+    return false;
+
+  MediaSource source(GetMediaSourceFromListener(listener));
+  PresentationMediaSinksObserver* sinks_observer =
+      new PresentationMediaSinksObserver(router_, listener, source);
+
+  if (!sinks_observer->is_active()) {
+    listener->OnScreenAvailabilityNotSupported();

[whywhat, 2015/09/29 12:29:22]

I think you need to make sinks_observer a scoped_ptr, otherwise you're leaking
memory here.

[mlamouri (slow - plz ping), 2015/09/29 14:44:52]

Good catch!

     return false;
   }
-  MediaSource source(GetMediaSourceFromListener(listener));
-  sinks_observer_.reset(
-      new PresentationMediaSinksObserver(router_, listener, source));
+
+  sinks_observer_.reset(sinks_observer);
   return true;
 }
 
 bool PresentationFrame::RemoveScreenAvailabilityListener(
     content::PresentationScreenAvailabilityListener* listener) {
   if (sinks_observer_ && sinks_observer_->listener() == listener) {
     sinks_observer_.reset();
     return true;
   }
   return false;
@@ skipping 544 matching lines @@
 bool PresentationServiceDelegateImpl::HasScreenAvailabilityListenerForTest(
     int render_process_id,
     int render_frame_id,
     const MediaSource::Id& source_id) const {
   RenderFrameHostId render_frame_host_id(render_process_id, render_frame_id);
   return frame_manager_->HasScreenAvailabilityListenerForTest(
       render_frame_host_id, source_id);
 }
 
 }  // namespace media_router