Use ExtractDrivePath(path()) instead of virtual_path() for getting Drive path.

Use ExtractDrivePath(path()) instead of virtual_path() for getting Drive path.

FileSystemURL::virtual_path is a superficial path specified by the user of
FileSystem API. It does not necessarily denote the 'virtual path' of Drive
files like drive/foo.txt, when the Drive filesystem is mounted onto of
another filesystem (e.g., onto an isolated filesystem). Basically,
virtual_path() should never be directly used inside the Drive filesystem.

BUG=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192962

[kinaba, 2013-04-08 03:43:04]

ptal

[hashimoto, 2013-04-08 03:51:00]

lgtm

https://codereview.chromium.org/13767002/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc (right):

https://codereview.chromium.org/13767002/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc:93:
EXPECT_EQ(base::FilePath(),
How about testing a case where |virtual_path| is different from |path|, if it's
not difficult?

[kinaba, 2013-04-08 05:47:50]

https://codereview.chromium.org/13767002/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc (right):

https://codereview.chromium.org/13767002/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc:93:
EXPECT_EQ(base::FilePath(),
On 2013/04/08 03:51:00, hashimoto wrote:
> How about testing a case where |virtual_path| is different from |path|, if
it's
> not difficult?

Done. I hope the things became clearer.

[hashimoto, 2013-04-08 06:03:49]

https://codereview.chromium.org/13767002/diff/7001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc (right):

https://codereview.chromium.org/13767002/diff/7001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc:97:
base::FilePath::FromUTF8Unsafe("/tmp"),  // partition_path
Using "/tmp" seems not multi platform friendly.
How about using base::ScopedTempDir?
The same goes for other "/tmp".

https://codereview.chromium.org/13767002/diff/7001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc:105:
base::FilePath::FromUTF8Unsafe("/special/drive"));
How about using drive::util::GetDriveMountPointPath() like
DriveSystemService::AddDriveMountPoint()?
The same goes for "drive".

https://codereview.chromium.org/13767002/diff/7001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc:126:
base::FilePath::FromUTF8Unsafe("/special/drive/bar/buz"),
How about using GetDriveMountPointPath()?

[kinaba, 2013-04-08 06:43:40]

https://codereview.chromium.org/13767002/diff/7001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc (right):

https://codereview.chromium.org/13767002/diff/7001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc:97:
base::FilePath::FromUTF8Unsafe("/tmp"),  // partition_path
On 2013/04/08 06:03:49, hashimoto wrote:
> Using "/tmp" seems not multi platform friendly.
> How about using base::ScopedTempDir?
> The same goes for other "/tmp".

Done.

https://codereview.chromium.org/13767002/diff/7001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc:105:
base::FilePath::FromUTF8Unsafe("/special/drive"));
On 2013/04/08 06:03:49, hashimoto wrote:
> How about using drive::util::GetDriveMountPointPath() like
> DriveSystemService::AddDriveMountPoint()?
> The same goes for "drive".

Done (and added a test for the case "drive" is not used as the mount name).

https://codereview.chromium.org/13767002/diff/7001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc:126:
base::FilePath::FromUTF8Unsafe("/special/drive/bar/buz"),
On 2013/04/08 06:03:49, hashimoto wrote:
> How about using GetDriveMountPointPath()?

Done.

[commit-bot: I haz the power, 2013-04-08 23:01:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/13767002/11004

[commit-bot: I haz the power, 2013-04-09 00:28:58]

Change committed as 192962