Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1376633005: Two minor cleanups in pattern rewriter (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Two minor cleanups in pattern rewriter - No need to call AsVariableProxy() on a VariableProxy - Reduce AST visitor boilerplate using pre-existing macro (and re-alphabetize the list of non-patterns). R=littledan@chromium.org Committed: https://crrev.com/c2c6323218ecdd30d8b1ed304c69d7643612fe85 Cr-Commit-Position: refs/heads/master@{#31032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M src/pattern-rewriter.cc View 4 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
adamk
5 years, 2 months ago (2015-09-30 19:27:20 UTC) #1
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-09-30 19:53:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376633005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376633005/1
5 years, 2 months ago (2015-09-30 19:56:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 20:22:33 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 20:22:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2c6323218ecdd30d8b1ed304c69d7643612fe85
Cr-Commit-Position: refs/heads/master@{#31032}

Powered by Google App Engine
This is Rietveld 408576698