Extend Annex B 3.3 sloppy-mode block-scoped hoisting to scripts, eval

test/mjsunit/harmony/block-sloppy-function.js

Index: test/mjsunit/harmony/block-sloppy-function.js
diff --git a/test/mjsunit/harmony/block-sloppy-function.js b/test/mjsunit/harmony/block-sloppy-function.js
index a17a4c0799c7d9bced58941597f0b150f532ee7b..a28c71b63b5e8defb47f37a2d8f743c8f76f96af 100644
--- a/test/mjsunit/harmony/block-sloppy-function.js
+++ b/test/mjsunit/harmony/block-sloppy-function.js
@@ -146,12 +146,21 @@
   assertEquals(2, f());
 })();
 
-// Test that hoisting from blocks doesn't happen in global scope
-function globalUnhoisted() { return 0; }
+// Test that hoisting from blocks does happen in global scope

[adamk, 2015/09/29 23:23:15]

More tests, please:

- Negative cases: does not hoist if there's a lexical in global scope (and test
the same in the eval case).

- Cases where there's no overlapping function already in the global; in that
case, add assertions that the property is created on the global (to make sure
the binding went in the right place), and with the expected attributes.

- Also add tests with a frozen global (does not hoist, does not throw).

- Finally, tests where you set up a global property with different attributes
from what you expect, and assertions of the actual current behavior (with a TODO
to fix).

Given how much of this is global, you might have to put some of these in
separate files...

+function globalHoisted() { return 0; }
 {
-  function globalUnhoisted() { return 1; }
+  function globalHoisted() { return 1; }
 }
-assertEquals(0, globalUnhoisted());
+assertEquals(1, globalHoisted());
+
+// Test that hoisting from blocks does happen in an eval
+eval(`
+  function evalHoisted() { return 0; }
+  {
+    function evalHoisted() { return 1; }
+  }
+  assertEquals(1, evalHoisted());
+`);
 
 // Test that shadowing arguments is fine
 (function shadowArguments(x) {