Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1376603007: Teach mojo_benchmark --save-traces to pull results from Android devices. (Closed)

Created:
5 years, 2 months ago by ppi
Modified:
5 years, 2 months ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Teach mojo_benchmark --save-traces to pull results from Android devices. Fixes domokit/devtools#48. R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7ee3c9f45ef8313b91d2be987cdc22cb18891551

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Address Etienne's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M mojo/devtools/common/mojo_benchmark View 5 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ppi
Hi Etienne, ptal.
5 years, 2 months ago (2015-10-01 16:49:26 UTC) #2
etiennej
https://codereview.chromium.org/1376603007/diff/20001/mojo/devtools/common/devtoolslib/android_shell.py File mojo/devtools/common/devtoolslib/android_shell.py (right): https://codereview.chromium.org/1376603007/diff/20001/mojo/devtools/common/devtoolslib/android_shell.py#newcode203 mojo/devtools/common/devtoolslib/android_shell.py:203: def get_tmp_dir_path(): Docstring please https://codereview.chromium.org/1376603007/diff/20001/mojo/devtools/common/devtoolslib/android_shell.py#newcode206 mojo/devtools/common/devtoolslib/android_shell.py:206: def pull_file(self, device_path, ...
5 years, 2 months ago (2015-10-02 10:58:05 UTC) #3
ppi
https://codereview.chromium.org/1376603007/diff/20001/mojo/devtools/common/devtoolslib/android_shell.py File mojo/devtools/common/devtoolslib/android_shell.py (right): https://codereview.chromium.org/1376603007/diff/20001/mojo/devtools/common/devtoolslib/android_shell.py#newcode203 mojo/devtools/common/devtoolslib/android_shell.py:203: def get_tmp_dir_path(): On 2015/10/02 10:58:05, etiennej wrote: > Docstring ...
5 years, 2 months ago (2015-10-03 21:48:49 UTC) #4
etiennej
lgtm
5 years, 2 months ago (2015-10-05 09:06:31 UTC) #5
ppi
5 years, 2 months ago (2015-10-05 20:16:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
7ee3c9f45ef8313b91d2be987cdc22cb18891551 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698