SSL in EmbeddedTestServer

components/cronet/android/test/native_test_server.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "native_test_server.h"
 
 #include <string>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
@@ skipping 33 matching lines @@
 // supports Sdch encoding. E.g. /sdch/index?q=LeQxM80O will make the server
 // responds with "Get-Dictionary: /sdch/dict/LeQxM80O".
 const char kSdchPath[] = "/sdch/index";
 // Path that returns encoded response if client has the right dictionary.
 const char kSdchTestPath[] = "/sdch/test";
 // Path where dictionaries are stored.
 const char kSdchDictPath[] = "/sdch/dict/";
 
 net::test_server::EmbeddedTestServer* g_test_server = nullptr;
 
 class CustomHttpResponse : public net::test_server::HttpResponse {

[mmenke, 2015/10/22 19:28:27]

Suggest renaming this...There's no collision, but since you're adding a public
class with this name, I think that's confusing.  Alternatively, rename the
other, per suggestion in other file.

[svaldez, 2015/10/22 20:00:17]

Removing and implementing as RawHttpResponse.

  public:
   CustomHttpResponse(const std::string& headers, const std::string& contents)
       : headers_(headers), contents_(contents) {}
 
-  std::string ToResponseString() const override {
-    return headers_ + "\r\n" + contents_;
+  void SendResponse(
+      const net::test_server::SendBytesCallback& send,
+      const net::test_server::SendCompleteCallback& done) override {
+    send.Run(headers_ + "\r\n" + contents_, done);
   }
 
   void AddHeader(const std::string& key_value_pair) {
     headers_.append(base::StringPrintf("%s\r\n", key_value_pair.c_str()));
   }
 
  private:
   std::string headers_;
   std::string contents_;
 
@@ skipping 262 matching lines @@
 #else
   return JNI_FALSE;
 #endif
 }
 
 bool RegisterNativeTestServer(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace cronet