SSL in EmbeddedTestServer

net/test/embedded_test_server/http_response.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/embedded_test_server/http_response.h"
 
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
 #include "net/http/http_status_code.h"
@@ skipping 15 matching lines @@
   std::string response_builder;
 
   std::string http_reason_phrase(GetHttpReasonPhrase(code_));
 
   // TODO(mtomasz): For http/1.0 requests, send http/1.0.
   base::StringAppendF(&response_builder,
                       "HTTP/1.1 %d %s\r\n",
                       code_,
                       http_reason_phrase.c_str());
   base::StringAppendF(&response_builder, "Connection: close\r\n");
-  base::StringAppendF(&response_builder,
-                      "Content-Length: %" PRIuS "\r\n",
-                      content_.size());
-  base::StringAppendF(&response_builder,
-                      "Content-Type: %s\r\n",
-                      content_type_.c_str());
+
+  if (content_type_.size() != 0 || content_.size() != 0) {
+    base::StringAppendF(&response_builder, "Content-Length: %" PRIuS "\r\n",
+                        content_.size());

[mmenke, 2015/10/19 18:07:41]

Why don't we send a content-length when when the content size is 0?

[svaldez, 2015/10/19 21:56:15]

For responses that are only sending headers back, having a Content-Length causes
the test to attempt to parse a body and fail when one isn't expected.

[mmenke, 2015/10/21 18:45:22]

I'm not following.  Our network stack handles Content-Lengths of 0.

+    base::StringAppendF(&response_builder, "Content-Type: %s\r\n",
+                        content_type_.c_str());
+  }
   for (size_t i = 0; i < custom_headers_.size(); ++i) {
     const std::string& header_name = custom_headers_[i].first;
     const std::string& header_value = custom_headers_[i].second;
     DCHECK(header_value.find_first_of("\n\r") == std::string::npos) <<
         "Malformed header value.";
     base::StringAppendF(&response_builder,
                         "%s: %s\r\n",
                         header_name.c_str(),
                         header_value.c_str());
   }
   base::StringAppendF(&response_builder, "\r\n");
 
   return response_builder + content_;
 }
 
+void BasicHttpResponse::SendResponse(SendBytesCallback send,
+                                     SendCompleteCallback done) {
+  send.Run(ToResponseString(), done);
+}
+
 }  // namespace test_server
 }  // namespace net