SSL in EmbeddedTestServer

net/test/embedded_test_server/http_response.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_TEST_EMBEDDED_TEST_SERVER_HTTP_RESPONSE_H_
 #define NET_TEST_EMBEDDED_TEST_SERVER_HTTP_RESPONSE_H_
 
 #include <map>

[mmenke, 2015/10/14 21:59:16]

While you're here, I don't think this is needed (This uses StringPairs instead
of a map for headers)

[svaldez, 2015/10/14 22:33:40]

Done.

 #include <string>
 
 #include "base/basictypes.h"
+#include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/strings/string_split.h"
 #include "net/http/http_status_code.h"
 
 namespace net {
 namespace test_server {
 
+// Callback called when the response is done being sent.
+using SendDoneCallback = base::Callback<void(void)>;

[mmenke, 2015/10/14 21:59:16]

Suggest Done->Complete (Complete's a bit more common in net/)

[svaldez, 2015/10/14 22:33:40]

Done.

+
+// Callback called when the response is ready to be sent.

[mmenke, 2015/10/14 21:59:16]

Document done.

[svaldez, 2015/10/14 22:33:40]

Done.

+using SendCallback =
+    base::Callback<void(std::string response, SendDoneCallback done)>;

[mmenke, 2015/10/14 21:59:16]

Suggest calling this SendBytesCallback to more clearly distinguish it from
SendResponse.

[svaldez, 2015/10/14 22:33:40]

Done.

+
 // Interface for HTTP response implementations.
 class HttpResponse{
  public:
   virtual ~HttpResponse();
 
-  // Returns raw contents to be written to the network socket
+  // Calls |send| with the raw contents to be written to the network socket
   // in response. If you intend to make this a valid HTTP response,
   // it should start with "HTTP/x.x" line, followed by response headers.
-  virtual std::string ToResponseString() const = 0;
+  // May call |send| reentrantly. If the HttpResponse is destroyed before
+  // the operation completes, the callback will not be called.

[mmenke, 2015/10/14 21:59:16]

Think this documentation should be targeted at implementations, rather than the
one consumer.

i.e. "|send| will send the specified data to the network socket, and invoke
|done| (Not this |done|, the other |done|) when complete.  When the entire
response is sent, |done| (This |done|, not the other one) must be called.

[svaldez, 2015/10/14 22:33:40]

Done.

+  virtual void SendResponse(SendCallback send, SendDoneCallback done) = 0;

[mmenke, 2015/10/14 21:59:16]

I assume you can use SendCallback and your own send done method to simulate
slowly receiving bytes - I don't think this is at all clear from the docs,
though.  If this is the case, should rename this one send_response_complete, and
the other one (In the typedef) send_complete.

[svaldez, 2015/10/14 22:33:40]

Done.

 };
 
 // This class is used to handle basic HTTP responses with commonly used
 // response headers such as "Content-Type".

[mmenke, 2015/10/14 21:59:16]

Maybe add something along the lines of "Sends the response instantly."

[svaldez, 2015/10/14 22:33:40]

Done.

 class BasicHttpResponse : public HttpResponse {
  public:
   BasicHttpResponse();
   ~BasicHttpResponse() override;
 
   // The response code.
   HttpStatusCode code() const { return code_; }
   void set_code(HttpStatusCode code) { code_ = code; }
 
   // The content of the response.
   const std::string& content() const { return content_; }
   void set_content(const std::string& content) { content_ = content; }
 
   // The content type.
   const std::string& content_type() const { return content_type_; }
   void set_content_type(const std::string& content_type) {
     content_type_ = content_type;
   }
 
   // Adds a custom header.
   void AddCustomHeader(const std::string& key, const std::string& value) {
     custom_headers_.push_back(std::make_pair(key, value));
   }
 
   // Generates and returns a http response string.
-  std::string ToResponseString() const override;
+  std::string ToResponseString() const;
+
+  void SendResponse(SendCallback send, SendDoneCallback done) override;
 
  private:
   HttpStatusCode code_;
   std::string content_;
   std::string content_type_;
   base::StringPairs custom_headers_;
 
   DISALLOW_COPY_AND_ASSIGN(BasicHttpResponse);
 };
 
 }  // namespace test_server
 }  // namespace net
 
 #endif  // NET_TEST_EMBEDDED_TEST_SERVER_HTTP_RESPONSE_H_