SSL in EmbeddedTestServer

net/test/embedded_test_server/http_response.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/embedded_test_server/http_response.h"
 
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
 #include "net/http/http_status_code.h"
@@ skipping 15 matching lines @@
   std::string response_builder;
 
   std::string http_reason_phrase(GetHttpReasonPhrase(code_));
 
   // TODO(mtomasz): For http/1.0 requests, send http/1.0.
   base::StringAppendF(&response_builder,
                       "HTTP/1.1 %d %s\r\n",
                       code_,
                       http_reason_phrase.c_str());
   base::StringAppendF(&response_builder, "Connection: close\r\n");
-  base::StringAppendF(&response_builder,
-                      "Content-Length: %" PRIuS "\r\n",
-                      content_.size());
-  base::StringAppendF(&response_builder,
-                      "Content-Type: %s\r\n",
-                      content_type_.c_str());
+
+  if (content_type_.size() != 0 || content_.size() != 0) {

[davidben, 2015/10/13 19:43:48]

This is to avoid sending empty headers in some cases I'm guessing? Do our
existing tests do this or was there some other reason? (Commit message doesn't
say anything about this.)

[svaldez, 2015/10/13 20:54:44]

This is for cases where we don't actually have a body (HEAD) and the tests
expect that we don't return a Content-Length.

+    base::StringAppendF(&response_builder, "Content-Length: %" PRIuS "\r\n",
+                        content_.size());
+    base::StringAppendF(&response_builder, "Content-Type: %s\r\n",
+                        content_type_.c_str());
+  }
   for (size_t i = 0; i < custom_headers_.size(); ++i) {
     const std::string& header_name = custom_headers_[i].first;
     const std::string& header_value = custom_headers_[i].second;
     DCHECK(header_value.find_first_of("\n\r") == std::string::npos) <<
         "Malformed header value.";
     base::StringAppendF(&response_builder,
                         "%s: %s\r\n",
                         header_name.c_str(),
                         header_value.c_str());
   }
   base::StringAppendF(&response_builder, "\r\n");
 
   return response_builder + content_;
 }
 
+void BasicHttpResponse::SendResponse(SendCallback send, SendDoneCallback done) {
+  send.Run(ToResponseString(), done);
+}
+
 }  // namespace test_server
 }  // namespace net