third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp - Issue 1376573004: Split out Color from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

Issue 1376573004: Split out Color from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_property

Patch Set: Rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl ('K') | « third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

index c838b682d6a8b860b88da1d3af7693f7936a2c96..1a4ff4f8ef338229f61916522a6be1ec52ff8d5f 100644

--- a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

@@ -151,7 +151,7 @@ void FilterOperationResolver::createFilterOperations(const CSSValue& inValue, co

int blur = item->blur ? item->blur->computeLength<int>(conversionData) : 0;

Color shadowColor = Color::black;

if (item->color)

- shadowColor = state.document().textLinkColors().colorFromPrimitiveValue(item->color.get(), state.style()->color());

+ shadowColor = state.document().textLinkColors().colorFromCSSValue(item->color.get(), state.style()->color());

operations.operations().append(DropShadowFilterOperation::create(location, blur, shadowColor));

break;