third_party/WebKit/Source/core/html/HTMLHRElement.cpp - Issue 1376573004: Split out Color from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLHRElement.cpp

Issue 1376573004: Split out Color from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_property

Patch Set: Rebase and review feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLHRElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLHRElement.cpp b/third_party/WebKit/Source/core/html/HTMLHRElement.cpp

index 97cc7f278a93e881b4a516c0e95faa63870a2bc5..f3b2f3c503c2afc119a70f6ea7c79d660514210d 100644

--- a/third_party/WebKit/Source/core/html/HTMLHRElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLHRElement.cpp

@@ -75,7 +75,7 @@ void HTMLHRElement::collectStyleForPresentationAttribute(const QualifiedName& na

if (!hasAttribute(colorAttr)) {

addPropertyToPresentationAttributeStyle(style, CSSPropertyBorderStyle, CSSValueSolid);

- RefPtrWillBeRawPtr<CSSPrimitiveValue> darkGrayValue = cssValuePool().createColorValue(Color::darkGray);

+ RefPtrWillBeRawPtr<CSSColorValue> darkGrayValue = cssValuePool().createColorValue(Color::darkGray);

style->setProperty(CSSPropertyBorderColor, darkGrayValue);

style->setProperty(CSSPropertyBackgroundColor, darkGrayValue);

}

« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingStyle.cpp ('k') | no next file » | no next file with comments »