third_party/WebKit/Source/core/dom/TextLinkColors.h - Issue 1376573004: Split out Color from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/TextLinkColors.h

Issue 1376573004: Split out Color from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_property

Patch Set: Rebase and review feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/TextLinkColors.h

diff --git a/third_party/WebKit/Source/core/dom/TextLinkColors.h b/third_party/WebKit/Source/core/dom/TextLinkColors.h

index 342ffb01bf5e928172ec4d29a86b7642dbc44ad5..66150381c90261c01a0cbe4d81c49cde2a8dbc7b 100644

--- a/third_party/WebKit/Source/core/dom/TextLinkColors.h

+++ b/third_party/WebKit/Source/core/dom/TextLinkColors.h

@@ -34,7 +34,7 @@

namespace blink {

-class CSSPrimitiveValue;

+class CSSValue;

class TextLinkColors {

DISALLOW_ALLOCATION();

@@ -54,7 +54,7 @@ public:

void resetLinkColor();

void resetVisitedLinkColor();

void resetActiveLinkColor();

- Color colorFromPrimitiveValue(const CSSPrimitiveValue&, Color currentColor, bool forVisitedLink = false) const;

+ Color colorFromCSSValue(const CSSValue&, Color currentColor, bool forVisitedLink = false) const;

private:

Color m_textColor;