third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h - Issue 1376573004: Split out Color from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 1376573004: Split out Color from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_property

Patch Set: Rebase and review feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

index e6750b4440d7c2815df334aa1a96f1e812cd1a91..3db84f62374a030d014fce59fc1d4d4077ac31f4 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

@@ -23,6 +23,7 @@

#ifndef CSSPropertyParser_h

#define CSSPropertyParser_h

+#include "core/css/CSSColorValue.h"

#include "core/css/CSSGradientValue.h"

#include "core/css/CSSGridTemplateAreasValue.h"

#include "core/css/CSSPropertySourceData.h"

@@ -202,7 +203,7 @@ private:

bool parseColorParameters(const CSSParserValue*, int* colorValues, bool parseAlpha);

bool parseHSLParameters(const CSSParserValue*, double* colorValues, bool parseAlpha);

- PassRefPtrWillBeRawPtr<CSSPrimitiveValue> parseColor(const CSSParserValue*, bool acceptQuirkyColors = false);

+ PassRefPtrWillBeRawPtr<CSSValue> parseColor(const CSSParserValue*, bool acceptQuirkyColors = false);

bool parseColorFromValue(const CSSParserValue*, RGBA32&, bool acceptQuirkyColors = false);

bool acceptQuirkyColors(CSSPropertyID) const;

@@ -337,7 +338,7 @@ private:

bool buildBorderImageParseContext(CSSPropertyID, BorderImageParseContext&);

bool parseDeprecatedGradientColorStop(CSSParserValue*, CSSGradientColorStop&);

- PassRefPtrWillBeRawPtr<CSSPrimitiveValue> parseDeprecatedGradientStopColor(const CSSParserValue*);

+ PassRefPtrWillBeRawPtr<CSSValue> parseDeprecatedGradientStopColor(const CSSParserValue*);

void commitBorderImageProperty(CSSPropertyID, PassRefPtrWillBeRawPtr<CSSValue>, bool important);