third_party/WebKit/Source/core/css/CSSValue.h - Issue 1376573004: Split out Color from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSValue.h

Issue 1376573004: Split out Color from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_property

Patch Set: Rebase and review feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSValue.h b/third_party/WebKit/Source/core/css/CSSValue.h

index fc982a07b4cab6c000638c7858c76ee69519e2e4..528c55e72d349b3980a3edec82363d22ebbbb912 100644

--- a/third_party/WebKit/Source/core/css/CSSValue.h

+++ b/third_party/WebKit/Source/core/css/CSSValue.h

@@ -72,6 +72,7 @@ public:

bool isBorderImageSliceValue() const { return m_classType == BorderImageSliceClass; }

bool isCanvasValue() const { return m_classType == CanvasClass; }

+ bool isColorValue() const { return m_classType == ColorClass; }

bool isCounterValue() const { return m_classType == CounterClass; }

bool isCursorImageValue() const { return m_classType == CursorImageClass; }

bool isCrossfadeValue() const { return m_classType == CrossfadeClass; }

@@ -122,6 +123,7 @@ protected:

static const size_t ClassTypeBits = 6;

enum ClassType {

PrimitiveClass,

+ ColorClass,

CounterClass,

QuadClass,

CustomIdentClass,