third_party/WebKit/Source/core/css/CSSGradientValue.h - Issue 1376573004: Split out Color from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSGradientValue.h

Issue 1376573004: Split out Color from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_property

Patch Set: Rebase and review feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSGradientValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSGradientValue.h b/third_party/WebKit/Source/core/css/CSSGradientValue.h

index 7d944e28edf890b41ebfd5f3faea2ffe89c5e60c..3add5eae41af48a8f0e540c230b162e0603f599d 100644

--- a/third_party/WebKit/Source/core/css/CSSGradientValue.h

+++ b/third_party/WebKit/Source/core/css/CSSGradientValue.h

@@ -56,7 +56,7 @@ struct CSSGradientColorStop {

public:

CSSGradientColorStop() : m_colorIsDerivedFromElement(false) { }

RefPtrWillBeMember<CSSPrimitiveValue> m_position; // percentage or length

- RefPtrWillBeMember<CSSPrimitiveValue> m_color;

+ RefPtrWillBeMember<CSSValue> m_color;

bool m_colorIsDerivedFromElement;

bool operator==(const CSSGradientColorStop& other) const

{