Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: third_party/WebKit/Source/core/animation/ListStyleInterpolationTest.cpp

Issue 1376573004: Split out Color from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_property
Patch Set: Rebase and review feedback Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/ListStyleInterpolationTest.cpp
diff --git a/third_party/WebKit/Source/core/animation/ListStyleInterpolationTest.cpp b/third_party/WebKit/Source/core/animation/ListStyleInterpolationTest.cpp
index 0123d87ee04546d2fdd4d133c9af6ec701724283..2f0fe7767535067fe9cb17b8351f4b2fc9c83762 100644
--- a/third_party/WebKit/Source/core/animation/ListStyleInterpolationTest.cpp
+++ b/third_party/WebKit/Source/core/animation/ListStyleInterpolationTest.cpp
@@ -7,6 +7,7 @@
#include "core/animation/LengthStyleInterpolation.h"
#include "core/animation/ShadowStyleInterpolation.h"
+#include "core/css/CSSColorValue.h"
#include <gtest/gtest.h>
@@ -45,7 +46,7 @@ protected:
static RefPtrWillBeRawPtr<CSSShadowValue> createShadowValue()
{
- RefPtrWillBeRawPtr<CSSPrimitiveValue> color = CSSPrimitiveValue::createColor(makeRGBA(112, 123, 175, 255));
+ RefPtrWillBeRawPtr<CSSColorValue> color = CSSColorValue::create(makeRGBA(112, 123, 175, 255));
RefPtrWillBeRawPtr<CSSPrimitiveValue> x = CSSPrimitiveValue::create(10, CSSPrimitiveValue::UnitType::Pixels);
RefPtrWillBeRawPtr<CSSPrimitiveValue> y = CSSPrimitiveValue::create(20, CSSPrimitiveValue::UnitType::Pixels);
RefPtrWillBeRawPtr<CSSPrimitiveValue> blur = CSSPrimitiveValue::create(30, CSSPrimitiveValue::UnitType::Pixels);
@@ -68,7 +69,7 @@ protected:
EXPECT_EQ(expectedShadow->y->getDoubleValue(), actualShadow->y->getDoubleValue());
EXPECT_EQ(expectedShadow->blur->getDoubleValue(), actualShadow->blur->getDoubleValue());
EXPECT_EQ(expectedShadow->spread->getDoubleValue(), actualShadow->spread->getDoubleValue());
- EXPECT_EQ(expectedShadow->color->getRGBA32Value(), actualShadow->color->getRGBA32Value());
+ EXPECT_EQ(toCSSColorValue(*expectedShadow->color).value(), toCSSColorValue(*actualShadow->color).value());
EXPECT_EQ(expectedShadow->style->getValueID(), actualShadow->style->getValueID());
}

Powered by Google App Engine
This is Rietveld 408576698