Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1376563003: Revert of [BackgroundSync] Trigger Background Sync events when Chrome is backgrounded on Android (Closed)

Created:
5 years, 2 months ago by iclelland
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, maniscalco+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [BackgroundSync] Trigger Background Sync events when Chrome is backgrounded on Android (patchset #20 id:400001 of https://codereview.chromium.org/1294603003/ ) Reason for revert: This patch breaks Android System WebView embedding, by assuming that ACCESS_NETWORK_STATE is available in all cases. NetworkChangeNotifierAutoDetect should not be created automatically by a WebView. Need to fix this before relanding this patch. Crashing bug report: https://crbug.com/537294 Original issue's description: > [BackgroundSync] Trigger Background Sync events when Chrome is backgrounded on Android > > BUG=511129 > > Committed: https://crrev.com/a5fb97d6fb9c3831994aadebea4664e2acc3c356 > Cr-Commit-Position: refs/heads/master@{#351093} TBR=jochen@chromium.org,jkarlin@chromium.org,yfriedman@chromium.org,mmenke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=511129 Committed: https://crrev.com/c532c674b657426cb733c2b735bbf5741bcbea48 Cr-Commit-Position: refs/heads/master@{#351381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -382 lines) Patch
M chrome/test/android/unit_tests_apk/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download
M components/test/DEPS View 2 chunks +0 lines, -2 lines 0 comments Download
M components/test/run_all_unittests.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D content/browser/android/background_sync_network_observer_android.h View 1 chunk +0 lines, -80 lines 0 comments Download
D content/browser/android/background_sync_network_observer_android.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/background_sync/background_sync_browsertest.cc View 6 chunks +15 lines, -35 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/background_sync/background_sync_manager_unittest.cc View 4 chunks +1 line, -16 lines 0 comments Download
M content/browser/background_sync/background_sync_network_observer.h View 2 chunks +4 lines, -19 lines 0 comments Download
M content/browser/background_sync/background_sync_network_observer.cc View 3 chunks +7 lines, -24 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_jni.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java View 1 chunk +0 lines, -96 lines 0 comments Download
M testing/android/native_test/java/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (2 generated)
iclelland
Created Revert of [BackgroundSync] Trigger Background Sync events when Chrome is backgrounded on Android
5 years, 2 months ago (2015-09-29 19:44:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376563003/1
5 years, 2 months ago (2015-09-29 19:45:20 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-09-29 19:45:22 UTC) #4
boliu
commiter stamp lgtm
5 years, 2 months ago (2015-09-29 19:46:51 UTC) #5
boliu
Can you include crbug.com/537294 too?
5 years, 2 months ago (2015-09-29 19:47:55 UTC) #6
iclelland
On 2015/09/29 19:47:55, boliu wrote: > Can you include crbug.com/537294 too? Do you mean in ...
5 years, 2 months ago (2015-09-29 19:51:33 UTC) #7
iclelland
On 2015/09/29 19:51:33, iclelland wrote: > On 2015/09/29 19:47:55, boliu wrote: > > Can you ...
5 years, 2 months ago (2015-09-29 19:52:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376563003/1
5 years, 2 months ago (2015-09-29 19:56:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 19:58:36 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c532c674b657426cb733c2b735bbf5741bcbea48 Cr-Commit-Position: refs/heads/master@{#351381}
5 years, 2 months ago (2015-09-29 20:00:03 UTC) #12
Yaron
5 years, 2 months ago (2015-09-29 21:18:24 UTC) #13
Message was sent while issue was closed.
On 2015/09/29 20:00:03, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/c532c674b657426cb733c2b735bbf5741bcbea48
> Cr-Commit-Position: refs/heads/master@{#351381}

It's fine to reference restricted bugs. The link will fail if someone doesn't
have access but it's still helpful to connect for those that do. :)

Powered by Google App Engine
This is Rietveld 408576698