Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1376553002: MD Settings: Expose CrPolicyIndicator.Type (Closed)

Created:
5 years, 2 months ago by michaelpg
Modified:
5 years, 2 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Expose CrPolicyIndicator.Type Allow MD Settings pages to specify policy indicator icon types. BUG=521791 Committed: https://crrev.com/3937c527105af63ce57b66cc2d462632941b7929 Cr-Commit-Position: refs/heads/master@{#351206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -38 lines) Patch
M ui/webui/resources/cr_elements/v1_0/policy/cr_policy_indicator.js View 4 chunks +43 lines, -38 lines 0 comments Download

Dependent Patchsets:

Issue 1367413002 Patch 40001
Issue 1367413002 Patch 60001
Issue 1367413002 Patch 80001

Messages

Total messages: 7 (2 generated)
michaelpg
Taken from https://codereview.chromium.org/1367413002/
5 years, 2 months ago (2015-09-28 18:59:34 UTC) #2
stevenjb
lgtm
5 years, 2 months ago (2015-09-28 19:16:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376553002/1
5 years, 2 months ago (2015-09-28 22:30:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 23:50:28 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 23:51:14 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3937c527105af63ce57b66cc2d462632941b7929
Cr-Commit-Position: refs/heads/master@{#351206}

Powered by Google App Engine
This is Rietveld 408576698