Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1376533003: Return correct name for default device in fake localization provider (Closed)

Created:
5 years, 2 months ago by Guido Urdaneta
Modified:
5 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return correct name for default device in fake localization provider BUG=537107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/base/fake_media_resources.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Guido Urdaneta
5 years, 2 months ago (2015-09-29 09:38:29 UTC) #2
Guido Urdaneta
On 2015/09/29 09:38:29, Guido Urdaneta wrote: For context, this is the CL that introduced the ...
5 years, 2 months ago (2015-09-29 09:44:51 UTC) #3
Guido Urdaneta
dalecurtis@chromium.org: PTAL
5 years, 2 months ago (2015-09-29 14:05:29 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376533003/1
5 years, 2 months ago (2015-09-29 14:06:02 UTC) #8
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 2 months ago (2015-09-29 14:06:04 UTC) #10
tommi (sloooow) - chröme
lgtm
5 years, 2 months ago (2015-09-29 14:51:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376533003/1
5 years, 2 months ago (2015-09-29 14:51:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104714)
5 years, 2 months ago (2015-09-29 15:00:38 UTC) #16
Guido Urdaneta
5 years, 2 months ago (2015-09-29 16:29:15 UTC) #17
Message was sent while issue was closed.
Closed due to revert of the offending CL landing before this fix.

Powered by Google App Engine
This is Rietveld 408576698