Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1376533002: [BackgroundSync] Add ability to disable Background Sync via Field Trial (Closed)

Created:
5 years, 2 months ago by jkarlin
Modified:
5 years, 2 months ago
Reviewers:
jsbell
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BackgroundSync] Add ability to disable Background Sync via Field Trial BUG=490488 Committed: https://crrev.com/39567426088f994d8ac63a563ebf344dcba2c566 Cr-Commit-Position: refs/heads/master@{#351179}

Patch Set 1 #

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M content/browser/background_sync/background_sync_manager.cc View 4 chunks +19 lines, -0 lines 0 comments Download
M content/browser/background_sync/background_sync_manager_unittest.cc View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jkarlin
jsbell@ PTAL
5 years, 2 months ago (2015-09-28 15:55:08 UTC) #2
jsbell
lgtm
5 years, 2 months ago (2015-09-28 16:23:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376533002/20001
5 years, 2 months ago (2015-09-28 16:26:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/74525)
5 years, 2 months ago (2015-09-28 17:50:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376533002/20001
5 years, 2 months ago (2015-09-28 22:20:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 22:41:30 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:42:46 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/39567426088f994d8ac63a563ebf344dcba2c566
Cr-Commit-Position: refs/heads/master@{#351179}

Powered by Google App Engine
This is Rietveld 408576698