Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Issue 1376523005: Fix four dangling header-file references in .gyp files (Closed)

Created:
5 years, 2 months ago by brucedawson
Modified:
5 years, 2 months ago
Reviewers:
Sami, sky
CC:
chromium-reviews, tfarina, dglazkov+blink, blink-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org, blink-reviews-api_chromium.org, tapted, Khushal
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix four dangling header-file references in .gyp files Fix misspelling of combobox_test_api.h in views.gyp in CL 1374523002. Move nestable_single_thread_task_runner.h to its new location in scheduler.gypi - it was missed in CL 1374653003 Fix missing commas in cc.gyp from CL 1357373002 Remove non-existent WebPageScheduler.h from blink_headers.gypi and add in WebFrameHostScheduler.h. It's unclear how this error appeared. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f27e6faf7a0e48b268c1371751b670fc2060b8d9 Cr-Commit-Position: refs/heads/master@{#352108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M cc/cc.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/scheduler.gypi View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
brucedawson
Fixing up some incorrect header-file references in .gyp files.
5 years, 2 months ago (2015-10-01 00:49:27 UTC) #3
Sami
cc and components/scheduler lgtm, thanks for the cleanup. By the way, do you have a ...
5 years, 2 months ago (2015-10-01 13:45:37 UTC) #4
sky
LGTM
5 years, 2 months ago (2015-10-02 15:48:10 UTC) #5
brucedawson
On 2015/10/01 13:45:37, Sami wrote: > cc and components/scheduler lgtm, thanks for the cleanup. > ...
5 years, 2 months ago (2015-10-02 17:18:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376523005/1
5 years, 2 months ago (2015-10-02 17:21:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 20:06:55 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 20:07:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f27e6faf7a0e48b268c1371751b670fc2060b8d9
Cr-Commit-Position: refs/heads/master@{#352108}

Powered by Google App Engine
This is Rietveld 408576698