Support 'pathLength' for stroking operations on <path>

Support 'pathLength' for stroking operations on <path>

This implements support for the 'pathLength' attribute on <path>.

BUG=536217
Committed: https://crrev.com/04aa03453f1e244c332d8bb9ca7bbb2dfaf47c6b
Cr-Commit-Position: refs/heads/master@{#373110}

[fs, 2016-02-01 16:15:21]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org

[fs, 2016-02-01 16:15:22]

Possibly ironic, but

https://github.com/w3c/svgwg/blob/master/master/images/painting/dash-pathleng...

still doesn't render 100% correctly (the leftmost "dot" isn't rendered). The
reason is unlikely to be a fatal flaw though. (More likely an accumulated error,
precision, not including end-points or something else)

[pdr., 2016-02-02 06:42:51]

I didn't have time to review this one today but I'll grab it tomorrow.

[davve, 2016-02-02 09:27:39]

davve@opera.com changed reviewers:
+ davve@opera.com

[davve, 2016-02-02 09:27:40]

Looks awesome. Non-owner LGTM for from me.

File issue on the missing dot?

https://codereview.chromium.org/1376523002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/stroke/pathlength-negative-expected.html
(right):

https://codereview.chromium.org/1376523002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/stroke/pathlength-negative-expected.html:3:
<path d="M10,10L110,10L110,110L10,110Z"  stroke-dashoffset="1"
stroke-dasharray="1 1"
Ultra-minor-nit-don't-even-bother-but-proves-that-I-read-through: double space.

[davve, 2016-02-02 09:28:59]

On 2016/02/02 09:27:40, David Vest wrote:
> Looks awesome. Non-owner LGTM for from me.

for _now_ from me, was I meaning to say.

[fs, 2016-02-02 11:16:38]

On 2016/02/02 at 09:27:40, davve wrote:
...
> File issue on the missing dot?

Wilco

https://codereview.chromium.org/1376523002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/stroke/pathlength-negative-expected.html
(right):

https://codereview.chromium.org/1376523002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/stroke/pathlength-negative-expected.html:3:
<path d="M10,10L110,10L110,110L10,110Z"  stroke-dashoffset="1"
stroke-dasharray="1 1"
On 2016/02/02 at 09:27:40, David Vest wrote:
> Ultra-minor-nit-don't-even-bother-but-proves-that-I-read-through: double
space.

Ultra-fixed

[f(malita), 2016-02-02 13:44:00]

LGTM

https://codereview.chromium.org/1376523002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp (right):

https://codereview.chromium.org/1376523002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp:77: if
(authorPathLength < 0 || !svgStyle.strokeDashArray()->size())
Is pathLength applicable beyond dashing? I'm assuming if we ever start using it
for something else we could relax this check and just rename the method?

[fs, 2016-02-02 13:47:23]

https://codereview.chromium.org/1376523002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp (right):

https://codereview.chromium.org/1376523002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp:77: if
(authorPathLength < 0 || !svgStyle.strokeDashArray()->size())
On 2016/02/02 at 13:44:00, f(malita) wrote:
> Is pathLength applicable beyond dashing? I'm assuming if we ever start using
it for something else we could relax this check and just rename the method?

It applies to <textPath> too I think, so I guess that's where it might turn
up/be needed next.

[pdr., 2016-02-02 21:23:47]

LGTM, this rules

[fs, 2016-02-02 22:11:15]

The CQ bit was checked by fs@opera.com

[fs, 2016-02-02 22:11:15]

The patchset sent to the CQ was uploaded after l-g-t-m from davve@opera.com
Link to the patchset: https://codereview.chromium.org/1376523002/#ps40001
(title: "Remove double space")

[commit-bot: I haz the power, 2016-02-02 22:17:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1376523002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1376523002/40001

[commit-bot: I haz the power, 2016-02-03 01:18:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-03 01:19:51]

Description was changed from

==========
Support 'pathLength' for stroking operations on <path>

This implements support for the 'pathLength' attribute on <path>.

BUG=536217
==========

to

==========
Support 'pathLength' for stroking operations on <path>

This implements support for the 'pathLength' attribute on <path>.

BUG=536217

Committed: https://crrev.com/04aa03453f1e244c332d8bb9ca7bbb2dfaf47c6b
Cr-Commit-Position: refs/heads/master@{#373110}
==========

[commit-bot: I haz the power, 2016-02-03 01:19:52]

Patchset 3 (id:??) landed as
https://crrev.com/04aa03453f1e244c332d8bb9ca7bbb2dfaf47c6b
Cr-Commit-Position: refs/heads/master@{#373110}