Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1376473007: Add the 'docRange' property and use it to compute documentation comment. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add the 'docRange' property and use it to compute documentation comment. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0ff03b00b88301dfc1348ab6b1ea4582296997f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+787 lines, -702 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +5 lines, -24 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 6 chunks +39 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_handle.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +5 lines, -23 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 15 chunks +680 lines, -655 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 15 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
5 years, 2 months ago (2015-10-02 21:11:45 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-02 22:08:54 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 0ff03b00b88301dfc1348ab6b1ea4582296997f0 (presubmit successful).
5 years, 2 months ago (2015-10-02 22:13:34 UTC) #3
Paul Berry
This CL causes the following test to start failing on my machine: python tools/test.py --checked ...
5 years, 2 months ago (2015-10-04 15:31:13 UTC) #5
scheglov
5 years, 2 months ago (2015-10-04 20:33:38 UTC) #6
Message was sent while issue was closed.
Thanks!
https://codereview.chromium.org/1384583007 should fix the failure.

Powered by Google App Engine
This is Rietveld 408576698