Notify NQE of TCP RTT values

net/socket/tcp_socket_win.h

Index: net/socket/tcp_socket_win.h
diff --git a/net/socket/tcp_socket_win.h b/net/socket/tcp_socket_win.h
index 1786af11ada0d8387e3ef08cd21eebc3c6c52636..22329ec0842aa6f4d52c1f7dbaeb42a1827022b0 100644
--- a/net/socket/tcp_socket_win.h
+++ b/net/socket/tcp_socket_win.h
@@ -17,6 +17,7 @@
 #include "net/base/address_family.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_export.h"
+#include "net/base/socket_performance_watcher.h"
 #include "net/log/net_log.h"
 
 namespace net {
@@ -28,7 +29,9 @@ class IPEndPoint;
 class NET_EXPORT TCPSocketWin : NON_EXPORTED_BASE(public base::NonThreadSafe),
                                 public base::win::ObjectWatcher::Delegate  {
  public:
-  TCPSocketWin(NetLog* net_log, const NetLog::Source& source);
+  TCPSocketWin(scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher,
+               NetLog* net_log,
+               const NetLog::Source& source);
   ~TCPSocketWin() override;
 
   int Open(AddressFamily family);
@@ -128,6 +131,10 @@ class NET_EXPORT TCPSocketWin : NON_EXPORTED_BASE(public base::NonThreadSafe),
 
   SOCKET socket_;
 
+  // Socket performance statistics may be reported to the
+  // |socket_performance_watcher_|. May be nullptr.

[Ryan Sleevi, 2016/04/11 22:06:57]

The first sentence doesn't add value; that's documenting
SocketPerformanceWatcher.

[tbansal1, 2016/04/12 16:14:34]

Done.

+  scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher_;

[Ryan Sleevi, 2016/04/11 22:06:57]

Given that this isn't used, this seems pointless to store for now. The only
reason I can conceive is to keep the lifetime tied to the socket object, but is
that part of the explicit API contract? If so, document it as such.

[tbansal1, 2016/04/12 16:14:34]

Added comment in tcp_client_socket.h

+
   HANDLE accept_event_;
   base::win::ObjectWatcher accept_watcher_;