content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc - Issue 1376473003: Notify NQE of TCP RTT values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added throttle on TCP socket notifications (with tests) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc ('k') | device/bluetooth/bluetooth_socket_net.cc » ('j') | net/base/network_quality_estimator_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

diff --git a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

index 661fdc52e5d38899bb47f322d638f694ac95751a..5c7391c2aae3c58cb12484ed7b28640059cf365c 100644

--- a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

+++ b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

@@ -76,7 +76,7 @@ PepperTCPSocketMessageFilter::PepperTCPSocketMessageFilter(

rcvbuf_size_(0),

sndbuf_size_(0),

address_index_(0),

- socket_(new net::TCPSocket(NULL, net::NetLog::Source())),

+ socket_(new net::TCPSocket(NULL, NULL, net::NetLog::Source())),

ssl_context_helper_(host->ssl_context_helper()),

pending_accept_(false),

pending_read_on_unthrottle_(false),

@@ -858,7 +858,7 @@ void PepperTCPSocketMessageFilter::OnConnectCompleted(

// We have to recreate |socket_| because it doesn't allow a second connect

// attempt. We won't lose any state such as bound address or set options,

// because in the private or v1.0 API, connect must be the first operation.

- socket_.reset(new net::TCPSocket(NULL, net::NetLog::Source()));

+ socket_.reset(new net::TCPSocket(NULL, NULL, net::NetLog::Source()));

if (address_index_ + 1 < address_list_.size()) {

DCHECK_EQ(version_, ppapi::TCP_SOCKET_VERSION_PRIVATE);