Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: net/socket/tcp_client_socket.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix SPW since different sockets may be created on different threads Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/tcp_client_socket.cc
diff --git a/net/socket/tcp_client_socket.cc b/net/socket/tcp_client_socket.cc
index d52f08c4166362cbbb4b51139e54c3c65b59d1f5..3a70dc47df86fada1cf5101681f764af449e7b16 100644
--- a/net/socket/tcp_client_socket.cc
+++ b/net/socket/tcp_client_socket.cc
@@ -14,18 +14,28 @@
#include "net/base/io_buffer.h"
#include "net/base/ip_endpoint.h"
#include "net/base/net_errors.h"
+#include "net/base/socket_performance_watcher.h"
namespace net {
-TCPClientSocket::TCPClientSocket(const AddressList& addresses,
- net::NetLog* net_log,
- const net::NetLog::Source& source)
- : socket_(new TCPSocket(net_log, source)),
+TCPClientSocket::TCPClientSocket(
+ const AddressList& addresses,
+ scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher,
+ net::NetLog* net_log,
+ const net::NetLog::Source& source)
+ : socket_performance_watcher_(
+ socket_performance_watcher.get()
+ ? socket_performance_watcher.get()->GetWeakPtr()
+ : base::WeakPtr<SocketPerformanceWatcher>()),
+ socket_(new TCPSocket(std::move(socket_performance_watcher),
+ net_log,
+ source)),
addresses_(addresses),
current_address_index_(-1),
next_connect_state_(CONNECT_STATE_NONE),
previously_disconnected_(false),
- total_received_bytes_(0) {}
+ total_received_bytes_(0),
+ notify_reset_socket_performance_watcher_(false) {}
TCPClientSocket::TCPClientSocket(scoped_ptr<TCPSocket> connected_socket,
const IPEndPoint& peer_address)
@@ -34,7 +44,8 @@ TCPClientSocket::TCPClientSocket(scoped_ptr<TCPSocket> connected_socket,
current_address_index_(0),
next_connect_state_(CONNECT_STATE_NONE),
previously_disconnected_(false),
- total_received_bytes_(0) {
+ total_received_bytes_(0),
+ notify_reset_socket_performance_watcher_(false) {
DCHECK(socket_);
socket_->SetDefaultOptionsForClient();
@@ -152,6 +163,10 @@ int TCPClientSocket::DoConnect() {
}
}
+ if (socket_performance_watcher_ && notify_reset_socket_performance_watcher_) {
+ socket_performance_watcher_->Reset();
+ }
+
// |socket_| is owned by this class and the callback won't be run once
// |socket_| is gone. Therefore, it is safe to use base::Unretained() here.
return socket_->Connect(endpoint,
@@ -195,6 +210,7 @@ void TCPClientSocket::DoDisconnect() {
// disconnected.
previously_disconnected_ = socket_->IsValid() && current_address_index_ >= 0;
socket_->Close();
+ notify_reset_socket_performance_watcher_ = true;
}
bool TCPClientSocket::IsConnected() const {

Powered by Google App Engine
This is Rietveld 408576698