net/quic/quic_network_transaction_unittest.cc - Issue 1376473003: Notify NQE of TCP RTT values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_network_transaction_unittest.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix SPW since different sockets may be created on different threads Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_network_transaction_unittest.cc

diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc

index b5a8d6d16a3e10182619ddc09ba06b534b9faa09..07362eb4e15a29a4e460d9b27ce2298c65e14f10 100644

--- a/net/quic/quic_network_transaction_unittest.cc

+++ b/net/quic/quic_network_transaction_unittest.cc

@@ -151,7 +151,7 @@ class TestNetworkQualityEstimator : public NetworkQualityEstimator {

scoped_ptr<SocketPerformanceWatcher> CreateSocketPerformanceWatcher(

const Protocol protocol) override {

if (protocol != PROTOCOL_QUIC) {

- NOTIMPLEMENTED();

+ return nullptr;

}

++watcher_count_;

return NetworkQualityEstimator::CreateSocketPerformanceWatcher(protocol);