chrome/browser/extensions/api/socket/tls_socket_unittest.cc - Issue 1376473003: Notify NQE of TCP RTT values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/tls_socket_unittest.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix SPW since different sockets may be created on different threads Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/socket/tls_socket_unittest.cc

diff --git a/chrome/browser/extensions/api/socket/tls_socket_unittest.cc b/chrome/browser/extensions/api/socket/tls_socket_unittest.cc

index 4c04b3550758f8d5d9e3236e1a59fd0836eab629..2f34572f567c51828b2275445b05c11e8882c812 100644

--- a/chrome/browser/extensions/api/socket/tls_socket_unittest.cc

+++ b/chrome/browser/extensions/api/socket/tls_socket_unittest.cc

@@ -87,7 +87,7 @@ class MockSSLClientSocket : public net::SSLClientSocket {

class MockTCPSocket : public net::TCPClientSocket {

public:

explicit MockTCPSocket(const net::AddressList& address_list)

- : net::TCPClientSocket(address_list, NULL, net::NetLog::Source()) {}

+ : net::TCPClientSocket(address_list, NULL, NULL, net::NetLog::Source()) {}

MOCK_METHOD3(Read,

int(net::IOBuffer* buf,