Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: net/socket/tcp_socket_posix.h

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More plumbing Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/tcp_socket_posix.h
diff --git a/net/socket/tcp_socket_posix.h b/net/socket/tcp_socket_posix.h
index 8d53caf567f38b96b6abfba189592b20865d7cff..31cc09579048cb7a5d272ae34bef9abde2867807 100644
--- a/net/socket/tcp_socket_posix.h
+++ b/net/socket/tcp_socket_posix.h
@@ -15,6 +15,7 @@
#include "net/base/address_family.h"
#include "net/base/completion_callback.h"
#include "net/base/net_export.h"
+#include "net/base/socket_performance_watcher.h"
#include "net/log/net_log.h"
namespace net {
@@ -26,7 +27,10 @@ class SocketPosix;
class NET_EXPORT TCPSocketPosix {
public:
- TCPSocketPosix(NetLog* net_log, const NetLog::Source& source);
+ TCPSocketPosix(
+ scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher,
+ NetLog* net_log,
+ const NetLog::Source& source);
virtual ~TCPSocketPosix();
int Open(AddressFamily family);
@@ -179,7 +183,7 @@ class NET_EXPORT TCPSocketPosix {
int BuildTcpSocketPosix(scoped_ptr<TCPSocketPosix>* tcp_socket,
IPEndPoint* address);
- void ConnectCompleted(const CompletionCallback& callback, int rv) const;
+ void ConnectCompleted(const CompletionCallback& callback, int rv);
int HandleConnectCompleted(int rv) const;
void LogConnectBegin(const AddressList& addresses) const;
void LogConnectEnd(int net_error) const;
@@ -197,12 +201,20 @@ class NET_EXPORT TCPSocketPosix {
int buf_len,
const CompletionCallback& callback);
+ // Notifies |socket_performance_watcher_| of the latest RTT estimate available
+ // from the tcp_info struct for this TCP socket.
+ void NotifySocketPerformanceWatcher();
+
// Called after the first read completes on a TCP FastOpen socket.
void UpdateTCPFastOpenStatusAfterRead();
scoped_ptr<SocketPosix> socket_;
scoped_ptr<SocketPosix> accept_socket_;
+ // Socket performance statistics (such as RTT) are reported to the
+ // |socket_performance_watcher_|. May be nullptr.
+ scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher_;
+
// Enables experimental TCP FastOpen option.
bool use_tcp_fastopen_;

Powered by Google App Engine
This is Rietveld 408576698