Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/socket/transport_client_socket_pool_unittest.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed rsleevi comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/socket/tcp_socket_posix.cc ('K') | « net/socket/transport_client_socket_pool_test_util.cc ('k') | net/socket/transport_client_socket_unittest.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/transport_client_socket_pool_unittest.cc
diff --git a/net/socket/transport_client_socket_pool_unittest.cc b/net/socket/transport_client_socket_pool_unittest.cc
index aeab2b18c63cb9d9f85c15a554b202b3d133cf89..c6cbce711653edb88cb5b75966cf3166db770c66 100644
--- a/net/socket/transport_client_socket_pool_unittest.cc
+++ b/net/socket/transport_client_socket_pool_unittest.cc
@@ -39,20 +39,19 @@ class TransportClientSocketPoolTest : public testing::Test {
TransportClientSocketPoolTest()
: connect_backup_jobs_enabled_(
ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(true)),
- params_(
- new TransportSocketParams(
- HostPortPair("www.google.com", 80),
- false,
- OnHostResolutionCallback(),
- TransportSocketParams::COMBINE_CONNECT_AND_WRITE_DEFAULT)),
+ params_(new TransportSocketParams(
+ HostPortPair("www.google.com", 80),
+ false,
+ OnHostResolutionCallback(),
+ TransportSocketParams::COMBINE_CONNECT_AND_WRITE_DEFAULT)),
host_resolver_(new MockHostResolver),
client_socket_factory_(&net_log_),
pool_(kMaxSockets,
kMaxSocketsPerGroup,
host_resolver_.get(),
&client_socket_factory_,
- NULL) {
- }
+ NULL,
+ NULL) {}
~TransportClientSocketPoolTest() override {
internal::ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(
@@ -857,11 +856,9 @@ TEST_F(TransportClientSocketPoolTest, BackupSocketFailAfterDelay) {
TEST_F(TransportClientSocketPoolTest, IPv6FallbackSocketIPv4FinishesFirst) {
// Create a pool without backup jobs.
ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(false);
- TransportClientSocketPool pool(kMaxSockets,
- kMaxSocketsPerGroup,
- host_resolver_.get(),
- &client_socket_factory_,
- NULL);
+ TransportClientSocketPool pool(kMaxSockets, kMaxSocketsPerGroup,
+ host_resolver_.get(), &client_socket_factory_,
+ NULL, NULL);
MockTransportClientSocketFactory::ClientSocketType case_types[] = {
// This is the IPv6 socket. It stalls, but presents one failed connection
@@ -908,11 +905,9 @@ TEST_F(TransportClientSocketPoolTest, IPv6FallbackSocketIPv4FinishesFirst) {
TEST_F(TransportClientSocketPoolTest, IPv6FallbackSocketIPv6FinishesFirst) {
// Create a pool without backup jobs.
ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(false);
- TransportClientSocketPool pool(kMaxSockets,
- kMaxSocketsPerGroup,
- host_resolver_.get(),
- &client_socket_factory_,
- NULL);
+ TransportClientSocketPool pool(kMaxSockets, kMaxSocketsPerGroup,
+ host_resolver_.get(), &client_socket_factory_,
+ NULL, NULL);
MockTransportClientSocketFactory::ClientSocketType case_types[] = {
// This is the IPv6 socket.
@@ -959,11 +954,9 @@ TEST_F(TransportClientSocketPoolTest, IPv6FallbackSocketIPv6FinishesFirst) {
TEST_F(TransportClientSocketPoolTest, IPv6NoIPv4AddressesToFallbackTo) {
// Create a pool without backup jobs.
ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(false);
- TransportClientSocketPool pool(kMaxSockets,
- kMaxSocketsPerGroup,
- host_resolver_.get(),
- &client_socket_factory_,
- NULL);
+ TransportClientSocketPool pool(kMaxSockets, kMaxSocketsPerGroup,
+ host_resolver_.get(), &client_socket_factory_,
+ NULL, NULL);
client_socket_factory_.set_default_client_socket_type(
MockTransportClientSocketFactory::MOCK_DELAYED_CLIENT_SOCKET);
@@ -994,11 +987,9 @@ TEST_F(TransportClientSocketPoolTest, IPv6NoIPv4AddressesToFallbackTo) {
TEST_F(TransportClientSocketPoolTest, IPv4HasNoFallback) {
// Create a pool without backup jobs.
ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(false);
- TransportClientSocketPool pool(kMaxSockets,
- kMaxSocketsPerGroup,
- host_resolver_.get(),
- &client_socket_factory_,
- NULL);
+ TransportClientSocketPool pool(kMaxSockets, kMaxSocketsPerGroup,
+ host_resolver_.get(), &client_socket_factory_,
+ NULL, NULL);
client_socket_factory_.set_default_client_socket_type(
MockTransportClientSocketFactory::MOCK_DELAYED_CLIENT_SOCKET);
@@ -1030,11 +1021,9 @@ TEST_F(TransportClientSocketPoolTest, IPv4HasNoFallback) {
TEST_F(TransportClientSocketPoolTest, TCPFastOpenOnIPv4WithNoFallback) {
// Create a pool without backup jobs.
ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(false);
- TransportClientSocketPool pool(kMaxSockets,
- kMaxSocketsPerGroup,
- host_resolver_.get(),
- &client_socket_factory_,
- NULL);
+ TransportClientSocketPool pool(kMaxSockets, kMaxSocketsPerGroup,
+ host_resolver_.get(), &client_socket_factory_,
+ NULL, NULL);
client_socket_factory_.set_default_client_socket_type(
MockTransportClientSocketFactory::MOCK_DELAYED_CLIENT_SOCKET);
// Resolve an AddressList with only IPv4 addresses.
@@ -1055,11 +1044,9 @@ TEST_F(TransportClientSocketPoolTest, TCPFastOpenOnIPv4WithNoFallback) {
TEST_F(TransportClientSocketPoolTest, TCPFastOpenOnIPv6WithNoFallback) {
// Create a pool without backup jobs.
ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(false);
- TransportClientSocketPool pool(kMaxSockets,
- kMaxSocketsPerGroup,
- host_resolver_.get(),
- &client_socket_factory_,
- NULL);
+ TransportClientSocketPool pool(kMaxSockets, kMaxSocketsPerGroup,
+ host_resolver_.get(), &client_socket_factory_,
+ NULL, NULL);
client_socket_factory_.set_default_client_socket_type(
MockTransportClientSocketFactory::MOCK_DELAYED_CLIENT_SOCKET);
// Resolve an AddressList with only IPv6 addresses.
@@ -1083,11 +1070,9 @@ TEST_F(TransportClientSocketPoolTest,
NoTCPFastOpenOnIPv6FailureWithIPv4Fallback) {
// Create a pool without backup jobs.
ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(false);
- TransportClientSocketPool pool(kMaxSockets,
- kMaxSocketsPerGroup,
- host_resolver_.get(),
- &client_socket_factory_,
- NULL);
+ TransportClientSocketPool pool(kMaxSockets, kMaxSocketsPerGroup,
+ host_resolver_.get(), &client_socket_factory_,
+ NULL, NULL);
MockTransportClientSocketFactory::ClientSocketType case_types[] = {
// This is the IPv6 socket.
@@ -1123,11 +1108,9 @@ TEST_F(TransportClientSocketPoolTest,
NoTCPFastOpenOnIPv6SuccessWithIPv4Fallback) {
// Create a pool without backup jobs.
ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(false);
- TransportClientSocketPool pool(kMaxSockets,
- kMaxSocketsPerGroup,
- host_resolver_.get(),
- &client_socket_factory_,
- NULL);
+ TransportClientSocketPool pool(kMaxSockets, kMaxSocketsPerGroup,
+ host_resolver_.get(), &client_socket_factory_,
+ NULL, NULL);
MockTransportClientSocketFactory::ClientSocketType case_types[] = {
// This is the IPv6 socket.
« net/socket/tcp_socket_posix.cc ('K') | « net/socket/transport_client_socket_pool_test_util.cc ('k') | net/socket/transport_client_socket_unittest.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698