Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Unified Diff: net/socket/tcp_client_socket_unittest.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed rsleevi comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/tcp_client_socket_unittest.cc
diff --git a/net/socket/tcp_client_socket_unittest.cc b/net/socket/tcp_client_socket_unittest.cc
index 5e0d948c32d40e6100da8baac40b8cdf3781fb37..ee7bd62e4b3dd92d3d0346a70102b922d1becec6 100644
--- a/net/socket/tcp_client_socket_unittest.cc
+++ b/net/socket/tcp_client_socket_unittest.cc
@@ -30,7 +30,8 @@ TEST(TCPClientSocketTest, BindLoopbackToLoopback) {
IPEndPoint server_address;
ASSERT_EQ(OK, server.GetLocalAddress(&server_address));
- TCPClientSocket socket(AddressList(server_address), NULL, NetLog::Source());
+ TCPClientSocket socket(AddressList(server_address), NULL, NULL,
+ NetLog::Source());
EXPECT_EQ(OK, socket.Bind(IPEndPoint(lo_address, 0)));
@@ -63,7 +64,7 @@ TEST(TCPClientSocketTest, BindLoopbackToExternal) {
IPAddressNumber external_ip;
ASSERT_TRUE(ParseIPLiteralToNumber("72.14.213.105", &external_ip));
TCPClientSocket socket(AddressList::CreateFromIPAddress(external_ip, 80),
- NULL, NetLog::Source());
+ NULL, NULL, NetLog::Source());
IPAddressNumber lo_address;
ASSERT_TRUE(ParseIPLiteralToNumber("127.0.0.1", &lo_address));
@@ -94,7 +95,8 @@ TEST(TCPClientSocketTest, BindLoopbackToIPv6) {
IPEndPoint server_address;
ASSERT_EQ(OK, server.GetLocalAddress(&server_address));
- TCPClientSocket socket(AddressList(server_address), NULL, NetLog::Source());
+ TCPClientSocket socket(AddressList(server_address), NULL, NULL,
+ NetLog::Source());
IPAddressNumber ipv4_lo_ip;
ASSERT_TRUE(ParseIPLiteralToNumber("127.0.0.1", &ipv4_lo_ip));

Powered by Google App Engine
This is Rietveld 408576698