extensions/browser/api/cast_channel/cast_socket.cc - Issue 1376473003: Notify NQE of TCP RTT values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_socket.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed rsleevi comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/cast_socket.cc

diff --git a/extensions/browser/api/cast_channel/cast_socket.cc b/extensions/browser/api/cast_channel/cast_socket.cc

index 6a330e3d6289ebf21e5aa471e3c13238f29284a0..239bc90bddddeaa7503868553bb939343bd9e22c 100644

--- a/extensions/browser/api/cast_channel/cast_socket.cc

+++ b/extensions/browser/api/cast_channel/cast_socket.cc

@@ -175,7 +175,7 @@ bool CastSocketImpl::audio_only() const {

scoped_ptr<net::TCPClientSocket> CastSocketImpl::CreateTcpSocket() {

net::AddressList addresses(ip_endpoint_);

return scoped_ptr<net::TCPClientSocket>(

- new net::TCPClientSocket(addresses, net_log_, net_log_source_));

+ new net::TCPClientSocket(addresses, nullptr, net_log_, net_log_source_));

// Options cannot be set on the TCPClientSocket yet, because the

// underlying platform socket will not be created until Bind()

// or Connect() is called.