google_apis/gcm/engine/connection_handler_impl_unittest.cc - Issue 1376473003: Notify NQE of TCP RTT values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_handler_impl_unittest.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reorder initialization in constructor Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/engine/connection_handler_impl_unittest.cc

diff --git a/google_apis/gcm/engine/connection_handler_impl_unittest.cc b/google_apis/gcm/engine/connection_handler_impl_unittest.cc

index 9ca9c6483ea346525bb2f1ca91d49398aebabf7c..97a026849ca60454ab3c568c0a160a6245cb2414 100644

--- a/google_apis/gcm/engine/connection_handler_impl_unittest.cc

+++ b/google_apis/gcm/engine/connection_handler_impl_unittest.cc

@@ -210,7 +210,7 @@ net::StreamSocket* GCMConnectionHandlerImplTest::BuildSocket(

socket_factory_.AddSocketDataProvider(data_provider_.get());

socket_ = socket_factory_.CreateTransportClientSocket(

- address_list_, NULL, net::NetLog::Source());

+ address_list_, NULL, NULL, net::NetLog::Source());

socket_->Connect(net::CompletionCallback());

run_loop_.reset(new base::RunLoop());