extensions/browser/api/socket/tcp_socket.cc - Issue 1376473003: Notify NQE of TCP RTT values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/socket/tcp_socket.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reorder initialization in constructor Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/socket/tcp_socket.cc

diff --git a/extensions/browser/api/socket/tcp_socket.cc b/extensions/browser/api/socket/tcp_socket.cc

index d4aaafbd6c226c18d99fa4d9df4c0fe1067a0462..9584c4805e511da916d9d87a7521f9ebd5b8ed99 100644

--- a/extensions/browser/api/socket/tcp_socket.cc

+++ b/extensions/browser/api/socket/tcp_socket.cc

@@ -99,7 +99,7 @@ void TCPSocket::Connect(const net::AddressList& address,

int result = net::ERR_CONNECTION_FAILED;

if (!is_connected_) {

socket_.reset(

- new net::TCPClientSocket(address, NULL, net::NetLog::Source()));

+ new net::TCPClientSocket(address, NULL, NULL, net::NetLog::Source()));

result = socket_->Connect(

base::Bind(&TCPSocket::OnConnectComplete, base::Unretained(this)));

}