chrome/test/chromedriver/net/adb_client_socket.cc - Issue 1376473003: Notify NQE of TCP RTT values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/net/adb_client_socket.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reorder initialization in constructor Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/net/adb_client_socket.cc

diff --git a/chrome/test/chromedriver/net/adb_client_socket.cc b/chrome/test/chromedriver/net/adb_client_socket.cc

index 73ec141d95a6a6cfa8719daa8d1f4c697d27deee..0a398acf8d3cdc0928d17bb95e6c203529058ffc 100644

--- a/chrome/test/chromedriver/net/adb_client_socket.cc

+++ b/chrome/test/chromedriver/net/adb_client_socket.cc

@@ -366,7 +366,7 @@ AdbClientSocket::~AdbClientSocket() {

void AdbClientSocket::Connect(const net::CompletionCallback& callback) {

net::AddressList address_list = net::AddressList::CreateFromIPAddress(

net::IPAddress::IPv4Localhost(), port_);

- socket_.reset(new net::TCPClientSocket(address_list, NULL,

+ socket_.reset(new net::TCPClientSocket(address_list, NULL, NULL,

net::NetLog::Source()));

int result = socket_->Connect(callback);

if (result != net::ERR_IO_PENDING)