chrome/browser/devtools/device/tcp_device_provider.cc - Issue 1376473003: Notify NQE of TCP RTT values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/tcp_device_provider.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reorder initialization in constructor Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/device/tcp_device_provider.cc

diff --git a/chrome/browser/devtools/device/tcp_device_provider.cc b/chrome/browser/devtools/device/tcp_device_provider.cc

index 3504f546df8053cd597b30627d007d0e9ccf3f2d..ea5b43ea9cc7ae1bd450c3a3bc5d70e3b296c043 100644

--- a/chrome/browser/devtools/device/tcp_device_provider.cc

+++ b/chrome/browser/devtools/device/tcp_device_provider.cc

@@ -52,8 +52,8 @@ class ResolveHostAndOpenSocket final {

delete this;

return;

}

- std::unique_ptr<net::StreamSocket> socket(

- new net::TCPClientSocket(address_list_, NULL, net::NetLog::Source()));

+ std::unique_ptr<net::StreamSocket> socket(new net::TCPClientSocket(

+ address_list_, NULL, NULL, net::NetLog::Source()));

socket->Connect(

base::Bind(&RunSocketCallback, callback_, base::Passed(&socket)));

delete this;