Notify NQE of TCP RTT values

net/socket/tcp_socket_win.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_TCP_SOCKET_WIN_H_
 #define NET_SOCKET_TCP_SOCKET_WIN_H_
 
 #include <stdint.h>
 #include <winsock2.h>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/threading/non_thread_safe.h"
 #include "base/win/object_watcher.h"
 #include "net/base/address_family.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_export.h"
+#include "net/base/socket_performance_watcher.h"
 #include "net/log/net_log.h"
 
 namespace net {
 
 class AddressList;
 class IOBuffer;
 class IPEndPoint;
 
 class NET_EXPORT TCPSocketWin : NON_EXPORTED_BASE(public base::NonThreadSafe),
                                 public base::win::ObjectWatcher::Delegate  {
  public:
-  TCPSocketWin(NetLog* net_log, const NetLog::Source& source);
+  TCPSocketWin(scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher,
+               NetLog* net_log,
+               const NetLog::Source& source);
   ~TCPSocketWin() override;
 
   int Open(AddressFamily family);
 
   // Both AdoptConnectedSocket and AdoptListenSocket take ownership of an
   // existing socket. AdoptConnectedSocket takes an already connected
   // socket. AdoptListenSocket takes a socket that is intended to accept
   // connection. In some sense, AdoptListenSocket is more similar to Open.
   int AdoptConnectedSocket(SOCKET socket, const IPEndPoint& peer_address);
   int AdoptListenSocket(SOCKET socket);
@@ skipping 79 matching lines @@
   void LogConnectBegin(const AddressList& addresses);
   void LogConnectEnd(int net_error);
 
   int DoRead(IOBuffer* buf, int buf_len, const CompletionCallback& callback);
   void DidCompleteConnect();
   void DidCompleteWrite();
   void DidSignalRead();
 
   SOCKET socket_;
 
+  // Socket performance statistics may be reported to the
+  // |socket_performance_watcher_|. May be nullptr.

[Ryan Sleevi, 2016/04/11 22:06:57]

The first sentence doesn't add value; that's documenting
SocketPerformanceWatcher.

[tbansal1, 2016/04/12 16:14:34]

Done.

+  scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher_;

[Ryan Sleevi, 2016/04/11 22:06:57]

Given that this isn't used, this seems pointless to store for now. The only
reason I can conceive is to keep the lifetime tied to the socket object, but is
that part of the explicit API contract? If so, document it as such.

[tbansal1, 2016/04/12 16:14:34]

Added comment in tcp_client_socket.h

+
   HANDLE accept_event_;
   base::win::ObjectWatcher accept_watcher_;
 
   scoped_ptr<TCPSocketWin>* accept_socket_;
   IPEndPoint* accept_address_;
   CompletionCallback accept_callback_;
 
   // The various states that the socket could be in.
   bool waiting_connect_;
   bool waiting_read_;
@@ skipping 17 matching lines @@
   bool logging_multiple_connect_attempts_;
 
   BoundNetLog net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(TCPSocketWin);
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_TCP_SOCKET_WIN_H_