Notify NQE of TCP RTT values

net/socket/client_socket_factory.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_CLIENT_SOCKET_FACTORY_H_
 #define NET_SOCKET_CLIENT_SOCKET_FACTORY_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "net/base/net_export.h"
 #include "net/base/rand_callback.h"
 #include "net/log/net_log.h"
 #include "net/udp/datagram_socket.h"
 
 namespace net {
 
 class AddressList;
 class ClientSocketHandle;
 class DatagramClientSocket;
 class HostPortPair;
+class SocketPerformanceWatcherFactory;
 class SSLClientSocket;
 struct SSLClientSocketContext;
 struct SSLConfig;
 class StreamSocket;
 
 // An interface used to instantiate StreamSocket objects.  Used to facilitate
 // testing code with mock socket implementations.
 class NET_EXPORT ClientSocketFactory {
  public:
   virtual ~ClientSocketFactory() {}
 
   // |source| is the NetLog::Source for the entity trying to create the socket,
   // if it has one.
   virtual scoped_ptr<DatagramClientSocket> CreateDatagramClientSocket(
       DatagramSocket::BindType bind_type,
       const RandIntCallback& rand_int_cb,
       NetLog* net_log,
       const NetLog::Source& source) = 0;
 
   virtual scoped_ptr<StreamSocket> CreateTransportClientSocket(
       const AddressList& addresses,
+      SocketPerformanceWatcherFactory* socket_performance_watcher_factory,

[Wez, 2016/03/04 18:50:26]

Is there any reason to pass a *factory* in here, rather than
scoped_ptr<Watcher>? The latter would make lifetime/ownership clearer[1] and it
seems that all any implementation will do is take an instance from the factory
anyway.

[1] Since with your change this call has two bare-pointer parameters, with
different lifetime requirements.

[tbansal1, 2016/03/09 00:20:03]

Right, done.

       NetLog* net_log,
       const NetLog::Source& source) = 0;
 
   // It is allowed to pass in a |transport_socket| that is not obtained from a
   // socket pool. The caller could create a ClientSocketHandle directly and call
   // set_socket() on it to set a valid StreamSocket instance.
   virtual scoped_ptr<SSLClientSocket> CreateSSLClientSocket(
       scoped_ptr<ClientSocketHandle> transport_socket,
       const HostPortPair& host_and_port,
       const SSLConfig& ssl_config,
       const SSLClientSocketContext& context) = 0;
 
   // Clears cache used for SSL session resumption.
   virtual void ClearSSLSessionCache() = 0;
 
   // Returns the default ClientSocketFactory.
   static ClientSocketFactory* GetDefaultFactory();
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_CLIENT_SOCKET_FACTORY_H_