Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1376463003: MD Downloads: change a lowercased, no-ink button to an <a> (Closed)

Created:
5 years, 2 months ago by Dan Beam
Modified:
5 years, 2 months ago
Reviewers:
esprehn
CC:
arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: change a lowercased, no-ink button to an <a> This is because it shaves 12 DOM nodes per "Show in Folder"... but it also looks good as well. Super. R=esprehn@chromium.org BUG=526577 Committed: https://crrev.com/acdd7ea3567e0efaf8d9f94b66833770c4bdf4da Cr-Commit-Position: refs/heads/master@{#351478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M chrome/browser/resources/md_downloads/item.css View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/shared_style.css View 1 chunk +1 line, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
Dan Beam
5 years, 2 months ago (2015-09-30 00:25:13 UTC) #1
esprehn
lgtm
5 years, 2 months ago (2015-09-30 00:58:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376463003/1
5 years, 2 months ago (2015-09-30 02:25:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 03:05:48 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 03:06:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acdd7ea3567e0efaf8d9f94b66833770c4bdf4da
Cr-Commit-Position: refs/heads/master@{#351478}

Powered by Google App Engine
This is Rietveld 408576698